Closed ned14 closed 9 years ago
Hi Niall, thanks for working on this porting.
Is there a way to see the whole set of modifications at once so that I don't get lost with the intermediary commits?
https://github.com/ptal/expected/pull/69/files is perfect. I will inspect it.
Niall, I have merged this patch. However, I'll not be able to maintain these compilers.
Please, don't hesitate to add other PR if we break these compiler by inadvertence.
Oh OK. I have my ci build this on Linux and windows every night so I will quickly see failure. Tomorrow I will try to add vs2013 support by replacing union with struct if the compiler does not support unrestricted unions. I'll see how it goes.
Vicente do you want me to add promise future here, or would prefer a separate library? If it is here you will see when you break it. I can make it so it can replace another future promise either in boost or in the stl, up to the person.
Nial, I think it is better to have a separated repository if you don't mind.
Do you have some code I could inspect?
Haven't even started yet Vicente. concurrent_unordered_map took me far longer than expected, I think something like ten weeks.
This is work I do in my free time, so non-alloc future-promise is likely to be slow going. Hopefully before Christmas.
Note this depends on the patch to Boost adding VS14 config support at https://svn.boost.org/trac/boost/ticket/10489.
It's actually very close to working on VS2013 too (see https://ci.nedprod.com/view/Boost%20Thread-Expected-Permit/job/Boost.Expected%20Test%20Win8%20VS2013/4/consoleFull). The only obstacle is the lack of unrestricted unions support, apart from that it appears to compile without issue now. Any suggestions on how to bypass the need for unrestricted unions would be welcome.