ptal / expected

What did you expect?
113 stars 18 forks source link

Shouldn't the default `error_traits::make_error` copy in the argument? #92

Closed russellmcc closed 8 years ago

russellmcc commented 8 years ago

Currently, the default error_traits class's make_error function ignores its argument. I think this is a mistake, and it should instead pass the argument to the constructor of Error.

viboes commented 8 years ago

Maybe you are right. However, currently it doesn't work, because the try-catch in some operations request the constructor of the error from the exception.

I will see what I can do.

viboes commented 8 years ago

https://github.com/ptal/expected/commit/932e6fdf5c8cc908c06a35cbd390ae1efec5d7b8

https://github.com/ptal/expected/commit/fefcc3e8d2a61c4bc96228795c5732ac3ba390f2