ptcrealitylab / vuforia-spatial-edge-server

Edge Server for the Vuforia Spatial Toolbox, a shared research platform for exploring spatial computing as a community
https://spatialtoolbox.vuforia.com
Mozilla Public License 2.0
20 stars 12 forks source link

isMobile server crashes if it tries to mkdir (e.g. the .identity in addon tools) #87

Open benptc opened 4 years ago

benptc commented 4 years ago

If the user creates a new addon with a tools directory, but they don't manually create a .identity folder within it for the frame metadata (enabled/disabled) to be saved, the server (and app) will crash.

Screen Shot 2020-03-10 at 1 29 05 PM
benptc commented 4 years ago

@hobinjk-ptc any idea if creating a directory is possible on the device? otherwise I might restructure so the metadata (json file) gets saved in each frame folder rather than them all going in a separate .identity folder (the .identity structure was meant to mirror the realityobjects directory back when this was the realityframes directory)

hobinjk-ptc commented 4 years ago

The behavior is very inconsistent, there are some directories it can create and some it can't. I think the best thing to do here is warn and not crash

realityLabDiscourseUser commented 4 years ago

This issue has been mentioned on Vuforia Spatial Toolbox Community. There might be relevant details there:

https://forum.spatialtoolbox.vuforia.com/t/test-github-linkback/31/1

valentinptc commented 4 years ago

have we resolved this by now?

valentinptc commented 4 years ago

I remove this from P-High, because it is actually not preventing the mobile app from operating rightfully. We should fix it, but its not triggered within normal app use.

hobinjk-ptc commented 4 years ago

It no longer crashes but we would ideally have a longer term solution than just checking each fs.mkdir callsite manually

valentinptc commented 4 years ago

should I close this issue or do we want to work more on it?