pteichman / cobe

A Markov chain based text generation library and MegaHAL style chatbot
http://teichman.org/blog/
MIT License
239 stars 51 forks source link

Argparse in requirements #18

Closed fitnr closed 9 years ago

fitnr commented 9 years ago

Is there a reason that argparse has a specific version requirement? The specific version is causing install errors for me when I have cobe listed as a dependency.

Since argparse is in the standard Python library, it's API should be pretty stable. Could the version specific version be removed or replaced with a lower bound?

pteichman commented 9 years ago

I always pin dependencies to specific revisions, because otherwise there's no way to ensure reproducible builds. Out of curiosity, what's the error you're seeing? I've got no problem with bumping the argparse version to 1.3.0 but want to make sure something else isn't going wrong.

fitnr commented 9 years ago

I have another dependency that specifies "argparse>=1.2.1", so setup.py install goes out and fetches the freshest argparse, which is 1.3.0. When it gets to cobe's requirements, it spits our this error: error: Installed distribution argparse 1.3.0 conflicts with requirement argparse==1.2.1

This is obviously a much deeper problem: since the two requirements are compatible there shouldn't be an error.

On a shallower level, I can fix it by specifying "argparse==1.2.1" on my project. Feel free to bump your requirements whenever it suits you - I'll know you did when my build breaks, but it will be a quick fix.