search

ptejasv / pe

0 stars 0 forks source link

Suboptimal diagram for Add Entry feature in DG #17

Open ptejasv opened 3 years ago

ptejasv commented 3 years ago

A sequence diagram may be more appropriate instead of the following diagram.

Screenshot 2021-11-12 at 5.36.08 PM.png

nus-se-bot commented 3 years ago

Team's Response

No explanation from the author on why "A sequence diagram may be more appropriate instead of the following diagram."

  1. If the author is aiming to convey that as per point 2 of the below instructions,

image.png

I should have used a UML diagram instead of some other diagram, then I would like to point out that the diagram used is a UML diagram(specifically, an activity diagram).

  1. If the author is stating that I need to use a sequence diagram instead of an activity diagram, I would like to point out that other diagrams within the journal feature are sequence diagrams, and the reason why an activity diagram was used here is because of the need to model the workflow for Add Entry feature considering that is a comparatively large feature and the readers of the developer guide would find it easier to understand the feature by getting an understanding of the flow of the use case.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]