search

ptelad / react-native-iphone-x-helper

A library to help you design your react-native app for notched iPhones
MIT License
942 stars 138 forks source link

Latest version doesn't support iPhone XR and XS Max #12

Closed WienerGames closed 6 years ago

WienerGames commented 6 years ago

Hello, great lib, keep it up! However, it looks like there is problem with the latest version ("1.2.0"). We just installed it in order to obtain support for apple's new iPhones, but it only works for one of them (1 out of 3). Basically, the lib doesn't recognize iPhone XR and XS Max. It only works for iPhone XS. I hope you fix that asap, as we depend on it. Best of luck!

zedtux commented 6 years ago

I'm also looking for this !

zedtux commented 6 years ago

To fix this package, this line should be updated in order to add the new phones dimensions.

zedtux commented 6 years ago

Well, actually I just saw that a PR exists, so actually this issue is a Bug report.

zedtux commented 6 years ago

And finally I just figured out that I have not updated the package in my project. @WienerGames have you upgraded the package in your project?

zedtux commented 6 years ago

Upgrading the package fixed the issue for me ! Sorry for the noise ! 🙇

ptelad commented 6 years ago

I'm glad it's working for you now :)