search

pteridin / flexlsx

R Package to add flextables to Excel files
Other
13 stars 2 forks source link

Unassigned workbook wrappers #13

Closed JanMarvin closed 11 months ago

JanMarvin commented 11 months ago

https://github.com/pteridin/flexlsx/blob/7247a520532cf93d95ced6d193878c312d1f6602/R/wb_apply.R#L734-L741

I’m traveling and was studying the flexlsx code and stumbled over this code snippet above and I’m not sure it works and if it works, it’s because of a bug in openxlsx2. The wb_ wrapper functions are not supposed to alter the workbook and either they need to be assigned (in a pipe workflow) to a workbook or the chain function should be used.

At the moment I suspect that these functions do not alter the workbook at all.

JanMarvin commented 11 months ago

Argh never mind, these are flexlsx functions using the chain version inside. Maybe Sunday evening is not a good time for code reading ☹️