search

pterodactyl-installer / pterodactyl-installer

:bird: Unofficial installation scripts for Pterodactyl Panel
https://pterodactyl-installer.se
GNU General Public License v3.0
1.41k stars 563 forks source link

Installer wont run on ubuntu 24.04 #488

Closed kweeks95 closed 4 months ago

kweeks95 commented 4 months ago

Describe the bug when attempting to run the installer via the command provided im prompted with an error message stating that ubuntu 24.04 is not supported ERROR: Unsupported OS.

It says on the home page of the pterodactyl-installer that ubuntu 24.04 is supported so im not sure why this is an issue.

Expected behaviour expect the installer to run and prompt with install options

Screenshots If applicable, add screenshots to help explain your problem.

OS (please complete the following information):

Additional context Add any other context about the problem here.

Linux123123 commented 4 months ago

Use the canary version of the script.

NewittAll commented 4 months ago

How? The installer doesn't say how, and not providing a solution doesn't help.

Linux123123 commented 4 months ago

Sorry, yes, the issue still persists as OS compatibility is still checked before the selection is allowed.

Here I have quickly changed the branch from which it pulls lib.sh

bash <(curl -s https://gist.githubusercontent.com/Linux123123/0c749c6bccfe812d4d28be0633e26d72/raw/0df407889d4ec75d70028eb2d9e99ba83d609f81/install.sh)
vilhelmprytz commented 4 months ago

@Linux123123 Can we do a long-term fix for this so that lib.sh is actually fetched from canary branch when canary version is selected by user?

Linux123123 commented 4 months ago

Yes, it's an oversight in m design of this install.sh with lib.sh. We would always need to fetch canary lib.sh at first and only after selecting a specific option refetching the correct version (canary/release), basically the other way around than we have now.

Fixed in https://github.com/pterodactyl-installer/pterodactyl-installer/commit/05c5efb8e1b56075d53cbb54abd2739735e07cda