search

pterodactyl / images

Generic docker images designed to work with Pterodactyl Panel and its daemon.
https://pterodactyl.io
MIT License
49 stars 182 forks source link

Zulu OpenJDK #51

Closed WGOS closed 4 years ago

WGOS commented 4 years ago
  1. Changed from OpenJDK to Zulu OpenJDK so that decreases amount of consumed RAM by 10-20% and loading speeds are faster by ~15%
  2. Changed to Alpine Linux due to lightweight
parkervcp commented 4 years ago

This could affect more than just the single server you ran. This is no from me.

Other servers could fail horribly with this.

DaneEveritt commented 4 years ago

I'm with @parkervcp here, but wouldn't be opposed to it being a new image that we host.

WGOS commented 4 years ago

This could affect more than just the single server you ran. This is no from me.

Other servers could fail horribly with this.

Well, it had been worked fine for me for years on different builds

I'm with @parkervcp here, but wouldn't be opposed to it being a new image that we host.

Yes, it's probably should be a new image Actually I uploaded it to Docker hub already wgos/pteroq-images:java-zulu so it could be tested

parkervcp commented 4 years ago

We have a Java open j9 image. So I don't see why we wouldn't add another jvm image.

I stop would rather have this be Debian based for compatibility reasons.

WGOS commented 4 years ago

It could be just an alternative option, I suppose.
Are there compatibility issues with Alpine? Just interesting

parkervcp commented 4 years ago

Alpine uses muslc and not glibc. This has caused issues with modded servers in the past. Before moving to debian we were running alpine-java-glibc but it used oracle java and got dcma'd.

parkervcp commented 4 years ago

Well that was gross and I am sorry I made all that noise there adding and changing the branch.

WGOS commented 4 years ago

Uh, that wasn't gross at all. Just a regular discussion

parkervcp commented 4 years ago

I was talking about all the changes and the merge conflict I added by changing the base branch.

WGOS commented 4 years ago

I also unmentioned that Forge does not work on OpenJ9 properly. In my case it freezes with Sponge and server doesn't launch

parkervcp commented 4 years ago

There is a reason openj9 isn't default...

WGOS commented 4 years ago

I finally resolved all problems with git so it may be ready to merge, I suppose

Base image changed to Debian. Also added "might-be-usefull" packages like in java branch

WGOS commented 4 years ago

As I see on Zulu in Alpine docker uses glibc (it's event stated on their site that glibc required). So maybe redo this container on Alpine due to lightweight?