pterodactyl / images

Generic docker images designed to work with Pterodactyl Panel and its daemon.
https://pterodactyl.io
MIT License
49 stars 182 forks source link

removing rcon.port form env #70

Closed fabri2000779 closed 3 years ago

fabri2000779 commented 3 years ago

Detect the rcon port from the startup command

parkervcp commented 3 years ago

This was fine and used the rcon environment variable just like the startup does.

fabri2000779 commented 3 years ago

is just a suggestion, i consider this useful in our case worked to automate the rcon assignment via WHMCS since you cant really change env variables throught the API without do API modifications, i may be wrong

fabri2000779 commented 3 years ago

feel free to close this PR if you think this isnt needed :)

parkervcp commented 3 years ago

It should work via whmcs if you set the variable value.

fabri2000779 commented 3 years ago

i was talking about our usecase but i see is not really needed here. Sorry for the inconvenience.