search

pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.72k stars 1.71k forks source link

Startup Variables Ignored By Wings #2255

Closed Zendrex closed 4 years ago

Zendrex commented 4 years ago

Background (please complete the following information):

Describe the bug It seems that any startup variables changed at server creation OR post-creation are ignored by wings, but are updated to the database. On top of this, the UI does not update the "startup command" string when variables are changed/saved.

Example: https://gyazo.com/f1953f67d0c59608b63f15130a7694ba

To Reproduce

  1. Create A Server / Select Existing Server
  2. Change Startup Command Variables
  3. Start/Restart Server
  4. See No Changes Executed

Expected behavior Startup variables to take effect. Wings seems to only use the default nest variables.

notAreYouScared commented 4 years ago

Does restarting wings pull new variables?

Zendrex commented 4 years ago

@Sir3lit I've attempted this before, and did again just now with no avail.

Corenb commented 4 years ago

It seems all variables aren't parsed (same for installation variables). When I running installation script, default variables are used instead of server variables.

DaneEveritt commented 4 years ago

It is quite possible I broke this unintentionally when I made changes to startup variable handling. I'm guessing the API is actually sending along incorrect values. You can confirm this by checking the server install logs in /var/log/pterodactyl I believe.

notAreYouScared commented 4 years ago

That does seem to be the issue. That it's passing the defaults to the install script.

matthewpi commented 4 years ago

Duplicate of #2261 (which has been resolved due to a pull request)

DaneEveritt commented 4 years ago

This isn't a duplicate.

Zendrex commented 4 years ago

@DaneEveritt Just tested RC2, however it seems that this issue still persists in some manner. Restarting wings does grab the correct variables, however updating them post-restart still doesn't update wings.

Zendrex commented 4 years ago

Also have learned that variables are still not updated in the log, however they seem to work within wings. https://gyazo.com/b902806d6d6ab2891fcd33e3523817f9 (parkervcp discordjs egg)

parkervcp commented 4 years ago

Also have learned that variables are still not updated in the log, however they seem to work within wings. https://gyazo.com/b902806d6d6ab2891fcd33e3523817f9 (parkervcp discordjs egg)

This is specific to how I am parsing the commands. I'm not going to sped a ton of time working on fixing that wither.