search

pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.66k stars 1.69k forks source link

Wings crashes servers & Kill button doesn't work #2986

Closed kakduman closed 3 years ago

kakduman commented 3 years ago

Background (please complete the following information):

Describe the bug The kill button sometimes does not work while the server is stopping. Servers seem to crash, then are marked as stopping, but never marked as stopped. Killing the server by pressing the kill button does not work during this time. Restarting wings will display them as stopped instead of stopping, and will allow you to start the server. One subuser reported that typing kill in the console allows the user to start the server afterward.

The crashes which cause the kill button to not work also aren't regular crashes. There is no crash report, and the server just stops for no reason.

To Reproduce Steps to reproduce the behavior: No clue. I've tried intentionally crashing the server with plugins and with exploits in outdated versions, but each time, the server stopped successfully. The regular kill button seems to work while the server is running, just not during one of these crashes. Still, I've had the bug happen 6 times to me on 3 different servers since I updated to 1.2.1 earlier today.

Neither of those servers have crashed since November, so it was odd that they crashed 5 times in the span of a few hours. I'm wondering if Wings is in some way causing these crashes.

Initially, I was thinking it was likely weird timing and just my fault, but I searched for "kill" in the Pterodactyl Discord and noticed three other people who had the same problem earlier today: Capture+_2021-01-07-19-46-18 Capture+_2021-01-07-19-46-03

Here are the Minecraft logs from one of the crashes: https://bin.birdflop.com/gimoducuhu

I posted the log in the Purpur Discord to ask for help, and here's what they said about it: Capture+_2021-01-07-20-07-17

Expected behavior The kill button should always work. Additionally, since Pterodactyl displays it as stopped after restarting wings, it's possible that the server is already stopped and not just stopping, so Pterodactyl should mark the server accordingly.

The server also shouldn't crash, but I can't be certain that Wings is causing these crashes.

BloomVPS commented 3 years ago

Same thing is happening to us since moving to 1.2.1

matthewpi commented 3 years ago

https://github.com/pterodactyl/wings/commit/66c9be357c5944f167a4c4e041c89f0bc4bda33e might be a potential fix, artifact can be downloaded from https://github.com/pterodactyl/wings/suites/1789671957/artifacts/34255649 but requires authentication I believe.

Xplodin commented 3 years ago

pterodactyl/wings@66c9be3 might be a potential fix, artifact can be downloaded from https://github.com/pterodactyl/wings/suites/1789671957/artifacts/34255649 but requires authentication I believe.

how can I apply this to my current wings? Im also having the same issue

junkees commented 3 years ago

My server crash when I update wings and panel to 1.2.1, kill doesnt work.

Game CS:GO.

matthewpi commented 3 years ago

pterodactyl/wings@66c9be3 might be a potential fix, artifact can be downloaded from https://github.com/pterodactyl/wings/suites/1789671957/artifacts/34255649 but requires authentication I believe.

how can I apply this to my current wings? Im also having the same issue

You just download it and replace the wings executable located at /usr/local/bin/wings

SecretlyJealous commented 3 years ago

There is an issue with the latest wings version, (I skipped 1.2.0 for 1.2.1 so this issue may or may not apply to 1.2.0) causing the server thread to hang on logging: Ptero wings crashing server The console will stop displaying updates after a certain amount of time even though the server is fine but the server will eventually hang and the only way to fix the issue is to kill the server instance and then restart wings because killing the server instance gets stuck. If you view the log file you can see how it says: "[14:54:37] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH" but after this it will just show a spam of uuid's. I had to use visualvm to find out what was going on.

For now I've reverted to Wings 1.1.3 because I was experiencing constant server crashes.

kakduman commented 3 years ago

Yeah, I'm having the same issue. I'd like to add that "[14:54:37] [Paper Watchdog Thread/ERROR]: --- DO NOT REPORT THIS TO PAPER - THIS IS NOT A BUG OR A CRASH" is because the watchdog doesn't have enough CPU for logging. Data from the console page supports that. When the server hangs, CPU usage is at around 2%. The UUID spam is from people trying to connect but not getting anywhere because the server can't process the login because it doesn't have enough CPU.

After using the dev build, it's happened 3 times on 2 different servers in the past 12 hours. I also noticed additional people in #help having issues with crashes, all on 1.2.1.

matthewpi commented 3 years ago

I'm still trying to wrap my head around how this would be caused by wings. No where in the code would wings terminate a server, no changes were made to the way CPU limits are applied or the output throttler. You may want to monitor htop if you are running v1.2.1 and can reproduce this to see how much resources wings is using as the only thing I could see happening is wings has a dead-lock in a go-routine which is causing a massive amount of CPU usage to become unavailable for other processes.

Xplodin commented 3 years ago

Ive noticed when i try starting a new server, that itd go normally then freeze at a certain point of loading. CPU would go up, then stop and sit at 17% which isnt normal for a heavy pack im running for minecraft.

Is there a fix besides downgrading wings and panel (if possible?) Trying to dev build of wings still has the same results

matthewpi commented 3 years ago

Potentially related to https://github.com/moby/moby/issues/41827

thewickening commented 3 years ago

This is still broken even after updating to this.

matthewpi commented 3 years ago

This issue should be resolved by the linked PR according to people in Discord. However this is still related to the issue with Docker itself.

DaneEveritt commented 3 years ago

Closed in https://github.com/pterodactyl/wings/commit/c9d972d544c154639022d1c6bf75f8ca1aff3926