Closed TekExplorer closed 2 years ago
Pretty hot idea ♨️
Would love this 😄
As far as I know, v2 will use yaml eggs. With that, all eggs have to be re-written, so there will probably a big improvement in the system anyway.
As far as I know, v2 will use yaml eggs. With that, all eggs have to be re-written, so there will probably a big improvement in the system anyway.
not necessarily. Json is valid yaml, after all.
Is there an existing feature request for this?
Describe the feature you would like to see.
Currently, eggs have docker images saved as a list. This has worked so far, but the
java_version
feature, when used on an egg that doesn't have the hard-coded images simply won't work.This is problematic, as features should be reusable by design since they can be added to any egg.
_As a side note,
eula
really should have been calledminecraft_eula
_Describe the solution you'd like.
Turning it into an object/map is better as then you can assign names to each image.
Ex: from
to
And it should be easy enough to support the list format by just setting the images' names to the image itself ex:
"ghcr.io\/pterodactyl\/yolks:java_8": "ghcr.io\/pterodactyl\/yolks:java_8"
Additional context to this request.
This should make the mentioned
java_version
image less jank and more reusable, and future features that might do something similar would find it easier to do so.