pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.7k stars 1.7k forks source link

Wrong Dates on #4075

Closed DemonMartin closed 2 years ago

DemonMartin commented 2 years ago

Current Behavior

When decompressing a .rar, the Dates in the panel say: "Dec 13th 1901 9:45PM"

Expected Behavior

The Dates from the decompressed files should be normal, or at least the Date of when the decompressing happened.

Steps to Reproduce

Using WinRAR, generate a maximum compressed .rar (not solid) Upload the file to pterodactyl Decompress it

Panel Version

1.7.0

Wings Version

1.6.1

Games and/or Eggs Affected

Any

Docker Image

Any

Error Logs

https://ptero.co/yzucapyjeq // no error
https://bin.ptdl.co/itirz/ // not relevant error

Is there an existing issue for this?

Ferks-FK commented 2 years ago

I don't think this is a problem, it only shows the date of the last modification of the file, not when it was extracted.

DemonMartin commented 2 years ago

Don't think my File got created 1901

parkervcp commented 2 years ago

Winrar may not write dates to files properly.

DaneEveritt commented 2 years ago

I cannot reproduce this, but I don't have WinRAR. My guess would be that of @parkervcp — it is probably not setting the data correctly. We already have hacks in the code to handle .rar files as is, it is not a highly supported format in this software.

I won't be making any changes to try and support this specific condition.