pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.61k stars 1.66k forks source link

Backups limit can be exceeded by bad cron schedule #4590

Closed diamkil closed 4 months ago

diamkil commented 1 year ago

Current Behavior

If a user that doesn't know cron (this is what happened for us) makes a backup task run every minute it allows them to exceed the backups limit somehow (older backups not getting deleted) Image of the cron schedule (we are helping them fix it, */168 makes it run everyday at 12 am for some reason). I know this is now an actually valid cron schedule, however hosting services such as us have clients that don't understand cron so the panel should take that into account.

Image of all the created backups

Expected Behavior

The backup limits at least gets applied and the oldest backup gets deleted

Steps to Reproduce

Create a backup schedule that runs every minute (make it exactly like the one in the screen shot, may be a bug from the */168, I'm not sure at the moment)

Panel Version

1.10.2

Wings Version

1.7.2

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

Logs don't include mention of the backups

Is there an existing issue for this?

Paddidox commented 1 year ago

0 /4

That's my Cron which is every 4 hours. I've configured a maximum of 10 backups for this server. I've got in my Cloudflare R2 around 50 objects.

Let me know if I can provide any data to debug.