pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.56k stars 1.64k forks source link

A way to change egg terminal type #4797

Open VasilisThePikachu opened 1 year ago

VasilisThePikachu commented 1 year ago

Is there an existing feature request for this?

Describe the feature you would like to see.

Im not really sure how to explain this so excuse me

I have been trying to make an egg for the open source game Space Station 14. The server software crashes with System.ArgumentOutOfRangeException: Count cannot be less than zero when attempting to send a command

Looking into their discord, some theory someone threw out was that the game expects an actual terminal and not a pty that Ptero gives all eggs at the current moment. This seems more like a ptero issue, ptero should be able to adapt to such cases and in theory support more games

Describe the solution you'd like.

Maybe a way in egg configuration to change how commands can be sent? I'm not really sure how this issue can exactly be resolved.

Additional context to this request.

I'm not exactly aware of the current bug so I can't provide that much information

Now yes the game in question could get an option to support the type of terminal that ptero uses, but i feel like its better for ptero to get some kind of support for this instead. It should not be relied onto the developer of the game to build support for pterodactyl, it should be as simple as running the executable

parkervcp commented 1 year ago

We use the standard docker tty terminal interface. if you run the server via docker and it runs with no issues then it should be fine on pterodactyl. The issue may be a parsing issue in the output to your terminal.

https://github.com/pterodactyl/wings/blob/bd26d6eefddcdbdc14779ae61b1ff126820241da/environment/docker/container.go#L182

VasilisThePikachu commented 1 year ago

Oh i forgot to be specific here, the server crashes if you attempt to send a command

VasilisThePikachu commented 1 year ago

So as it turns out my issue is related to a window width/height not being provided. I will keep this open for now, don't know if I should use this issue or make a new one though since i feel like it would solve the problem