pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.65k stars 1.68k forks source link

Upgrading Wings moves the default location back to /var/lib/pterodactyl/volumes and not whatever was set. #4931

Closed VanillaChan6571 closed 4 months ago

VanillaChan6571 commented 10 months ago

Current Behavior

When upgrading wings. The volume location if set custom like /panel/volumes it will revert back to the default location volumes of /var/lib/pterodactyl/volumes because configuration believes its always located /var/lib/pterodactyl/volumes and not whatever the config says and no way to overwrite admin/nodes/view/XYZ/configuration

Expected Behavior

It should never reset or move the default location of volumes when upgrading.

Steps to Reproduce

  1. Upgrade Wings
  2. All files go missing
  3. Get Confused because wings should never move location of volumes.
  4. Check the /etc/pterodactyl/config.yml
  5. Sure enough it moved the location back to /var/lib/pterodactyl/volumes

Panel Version

1.11.3

Wings Version

1.11.8

Games and/or Eggs Affected

N/A

Docker Image

N/A

Error Logs

N/A due to a wings config issue not a log issue.

Is there an existing issue for this?

danny6167 commented 10 months ago

You need to set the data path in the database if you didn't set it right when you created the node, or moved it after the fact.

Wings will update parts of its configuration from the panel when it restarts. it's not defaulting, it's using the value you have set for the node in the database

VanillaChan6571 commented 10 months ago

@danny6167 what? There is no database for "nodes"

danny6167 commented 10 months ago

@danny6167 what? There is no database for "nodes"

Of course there is. How else do you think the panel keeps a record of its nodes.

VanillaChan6571 commented 10 months ago

@danny6167 what? There is no database for "nodes"

Of course there is. How else do you think the panel keeps a record of its nodes.

The panel keeps the nodes records in the config.yml, the nodes have no database connection except api calls to the master webhost. YOU have no idea what your talking about.

danny6167 commented 10 months ago

@danny6167 what? There is no database for "nodes"

Of course there is. How else do you think the panel keeps a record of its nodes.

The panel keeps the nodes records in the config.yml, the nodes have no database connection except api calls to the master webhost. YOU have no idea what your talking about.

Actually you have no idea what you are talking about.

The config.yml is there to store the basic settings for the wings service to start up. But the panel doesn't read it at all, it stores all of it's information in the panels database.

danny6167 commented 10 months ago

image

VanillaChan6571 commented 10 months ago

@danny6167 what? There is no database for "nodes"

Of course there is. How else do you think the panel keeps a record of its nodes.

The panel keeps the nodes records in the config.yml, the nodes have no database connection except api calls to the master webhost. YOU have no idea what your talking about.

Actually you have no idea what you are talking about.

The config.yml is there to store the basic settings for the wings service to start up. But the panel doesn't read it at all, it stores all of it's information in the panels database.

No I do as you didnt even read what I posted. "/var/lib/pterodactyl/volumes" is located in config.yml and NO WHERE in any database. Your talking about something else.

VanillaChan6571 commented 10 months ago

image

I do not have a "demonBase" as it marked as - for every node.

danny6167 commented 10 months ago

I just showed you where it is in the database.

As I explained before, when wings pulls updated config data from the panel it will update your config.yml with details from the panel database.

At no point did I ever say wings had a direct connection to the panels database. It is done when wings calls the panels API for settings.

VanillaChan6571 commented 10 months ago

So basically editing the config is useless and needs to be updated via database which has a one way talking point which in the dumbest way to store volume locations as it should be called on the config when requesting wings. or when wings restarts it should send a updated copy to the database no matter what

danny6167 commented 10 months ago

For some values, yes. you need to update them in the panels database.

You can also set ignore_panel_config_updates to true in your wings config and it will ignore config updates from the panel.