search

pterodactyl / panel

Pterodactyl® is a free, open-source game server management panel built with PHP, React, and Go. Designed with security in mind, Pterodactyl runs all game servers in isolated Docker containers while exposing a beautiful and intuitive UI to end users.
https://pterodactyl.io
Other
6.61k stars 1.66k forks source link

Don't display the port of a server if the allocation alias is set. #4954

Open LaserKaspar opened 8 months ago

LaserKaspar commented 8 months ago

Is there an existing feature request for this?

Describe the feature you would like to see.

image to image

Describe the solution you'd like.

Either a permanent change, an option in .env of the panel, or some other config.

Additional context to this request.

Simple modification to ServerDetailsBlock.tsx#L66 I have on my instance. I don't know if this feature is in the interest of the general public, but I think it makes "normal" users of the panel less confused (we use aliases to assign them subdomains).

Anyways, great panel!

QuintenQVD0 commented 8 months ago

You can not allocate port 80? Or any port lower then 1024?

The alias is just there to show a domain. So that for game servers you can connect to domain:port instad of needing to remember the ip.

devnote-dev commented 8 months ago

That's irrelevant to the issue. Some tools/services/etc. require the port to be specified in cases that the domain (or alias in this case) is ambiguous. Removing it could lead to many different issues, and to be honest there isn't really a reason to do so other than visual aesthetics.

LaserKaspar commented 8 months ago

Ok, then I'll just keep it for my instance. The only reason for it is aesthetics and it's easier to copy/paste the thing you want. But as aliases are assigned per allocation, maybe a toggle option to hide a port on a specified allocation wouldn't break stuff for people that don't want it and the ones who do, can easily enable it?

The alias is just there to show a domain. So that for game servers you can connect to domain:port instad of needing to remember the ip.

Exactly, some game servers allow to specify a port via a srv record so you don't even have to remember the port.

Jcodeerd commented 8 months ago

Imo this should be toggleable per server, some servers might just use an A record instead of SRV for example

LaserKaspar commented 8 months ago

Maybe on a per egg basis? But per Server would also be great.

Codixer commented 8 months ago

I would say to have this per egg AND based on if the alias is set:

✅ - Alias ❌ - Feature enabled ❌ - Port still shows

❌ - Alias ✅ - Feature enabled ❌ - Port still shows

✅ - Alias ✅ - Feature enabled ✅ - Port is hidden.

LaserKaspar commented 8 months ago

Another possibility would be introducing a new kind of alias (maybe per Server) that just completely overwrites the Address field for the user.