docker_image validation prevents local images

danny6167 commented 2 months ago

Current Behavior

"The image format is invalid." error is received when attempting to use an image starting with ~ (local image)

Expected Behavior

Image names beginning with ~ should be accepted

Steps to Reproduce

Enter a docker image starting with ~

Panel Version

1.11.7

Wings Version

N/A

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

[X] I have searched the existing issues before opening this issue.
[X] I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
[X] I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

QuintenQVD0 commented 2 months ago

If you build a local image with the -t flag it still works as you can then just use dev:latest?

stive101 commented 2 months ago

with quintens soution it will work, u need to tag dev:latest to your image, and after that dev:latest is your new image name, with that u can start you custom image, thanks again Quinten, i try to figure out what i can do here for hours now ;=)

danny6167 commented 2 months ago

Yeah it still needs to be fixed though as this isn't going to work for all cases.

I'll submit a fix in a few hours.

danny6167 commented 2 months ago

I've submitted a PR. If you need to fix this before the next release you can apply the patch as such

cd /var/www/pterodactyl
curl https://patch-diff.githubusercontent.com/raw/pterodactyl/panel/pull/5103.patch | patch -p1

pterodactyl / panel