pthom / imgui_manual

https://pthom.github.io/imgui_manual_online - an interactive manual for ImGui
MIT License
304 stars 23 forks source link

Gitpod Sample - make fail #12

Open fredkwok-it opened 1 month ago

fredkwok-it commented 1 month ago

While I am playing around the Gitpod sample - https://pthom-imguimanual-ddodw9hmo84.ws-us114.gitpod.io/

When I did the first make, I got follow error. Is it something outdated on Gitpod repository?

[ 50%] Building CXX object external/hello_imgui/src/hello_imgui/CMakeFiles/hello_imgui.dir/internal/backend_impls/backend_window_helper/sdl_window_helper.cpp.o
/workspace/imgui_manual/external/hello_imgui/src/hello_imgui/internal/backend_impls/backend_window_helper/sdl_window_helper.cpp:94:29: error: use of undeclared identifier 'SDL_WINDOW_METAL'; did you mean 'SDL_WINDOW_OPENGL'?
            window_flags |= SDL_WINDOW_METAL;
                            ^~~~~~~~~~~~~~~~
                            SDL_WINDOW_OPENGL
/home/gitpod/emsdk/upstream/emscripten/cache/sysroot/include/SDL2/SDL_video.h:101:5: note: 'SDL_WINDOW_OPENGL' declared here
    SDL_WINDOW_OPENGL = 0x00000002,             /**< window usable with OpenGL context */
    ^
/workspace/imgui_manual/external/hello_imgui/src/hello_imgui/internal/backend_impls/backend_window_helper/sdl_window_helper.cpp:172:36: error: use of undeclared identifier 'SDL_FLASH_UNTIL_FOCUSED'
        SDL_FlashWindow(sdlWindow, SDL_FLASH_UNTIL_FOCUSED);
                                   ^
2 errors generated.
pthom commented 1 month ago

Sorry I do not maintain the gitpod example anymore. I should remove it from the repository.

pthom commented 1 month ago

But you can comment out the lines that fail, it should work. This is due to the fact that the SDL version shipped with emscripten is out of date.