codecov[bot]
commented
1 year ago Codecov Report
Base: 75.08% // Head: 51.62% // Decreases project coverage by -23.47% :warning:
Coverage data is based on head (
07a2f81) compared to base (be23ffe). Patch coverage: 34.55% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #189 +/- ## =========================================== - Coverage 75.08% 51.62% -23.47% =========================================== Files 27 32 +5 Lines 2115 3177 +1062 =========================================== + Hits 1588 1640 +52 - Misses 527 1537 +1010 ``` | [Impacted Files](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede) | Coverage Δ | | |---|---|---| | [src/Comrade.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL0NvbXJhZGUuamw=) | `100.00% <ø> (ø)` | | | [src/inference/inference.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2luZmVyZW5jZS9pbmZlcmVuY2Uuamw=) | `0.00% <0.00%> (ø)` | | | [src/inference/pullbacks.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2luZmVyZW5jZS9wdWxsYmFja3Muamw=) | `0.00% <0.00%> (ø)` | | | [src/models/misc.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL21vZGVscy9taXNjLmps) | `0.00% <0.00%> (ø)` | | | [src/observations/observations\_proposal.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL29ic2VydmF0aW9ucy9vYnNlcnZhdGlvbnNfcHJvcG9zYWwuamw=) | `0.00% <0.00%> (ø)` | | | [src/rules.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3J1bGVzLmps) | `0.00% <0.00%> (ø)` | | | [src/visualizations/data.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3Zpc3VhbGl6YXRpb25zL2RhdGEuamw=) | `48.92% <16.61%> (-45.40%)` | :arrow_down: | | [src/calibration/jones.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2NhbGlicmF0aW9uL2pvbmVzLmps) | `18.84% <18.84%> (ø)` | | | [src/calibration/gains.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2NhbGlicmF0aW9uL2dhaW5zLmps) | `6.66% <20.00%> (-53.85%)` | :arrow_down: | | [src/visualizations/intensitymap.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3Zpc3VhbGl6YXRpb25zL2ludGVuc2l0eW1hcC5qbA==) | `25.49% <23.73%> (-70.35%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/ptiede/Comrade.jl/pull/189?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
During testing a noticed that the gains are highly correlated, likely due to struggles with phase centering. This means that gains of the same station are often perfectly correlated in time. This creates havoc when sampling. To fix this this pull-request will add a transformation to gain variables that fits the relative gain from scan to scan rather than the absolute gain of each scan. This is basically a centered parameterization of the model.