ptiede / Comrade.jl

MIT License
48 stars 7 forks source link

Add Better segmentation to caches #207

Closed ptiede closed 6 months ago

ptiede commented 1 year ago

We generalize some of the data segmentation stuff we are doing. First ScanSeg and IntegSeg both do the same thing right now, because ScanSeg doesn't actually read the scan table because and EHTObservation object doesn't track it.

This pull-request will add a scan property to EHT observation that tracks the scan times and then fix the IntegSeg to actually segment arbritrary data times.

codecov[bot] commented 1 year ago

Codecov Report

Base: 51.58% // Head: 51.58% // No change to project coverage :thumbsup:

Coverage data is based on head (d302c79) compared to base (036e794). Patch has no changes to coverable lines.

:exclamation: Current head d302c79 differs from pull request most recent head 566988a. Consider uploading reports for the commit 566988a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #207 +/- ## ======================================= Coverage 51.58% 51.58% ======================================= Files 32 32 Lines 3181 3181 ======================================= Hits 1641 1641 Misses 1540 1540 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ptiede commented 6 months ago

Superseded by #346