ptiede / Comrade.jl

MIT License
43 stars 8 forks source link

Try to fix gradient bug #296

Closed ptiede closed 1 year ago

ptiede commented 1 year ago

There is a slight issue with geometric polarized models. This will fix this issue and transfer everything to Enzyme 0.11

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -64.56 :warning:

Comparison is base (a463a53) 83.27% compared to head (4ba1333) 18.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## =========================================== - Coverage 83.27% 18.72% -64.56% =========================================== Files 36 36 Lines 3378 3333 -45 =========================================== - Hits 2813 624 -2189 - Misses 565 2709 +2144 ``` | [Impacted Files](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede) | Coverage Δ | | |---|---|---| | [src/Comrade.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL0NvbXJhZGUuamw=) | `80.00% <ø> (-20.00%)` | :arrow_down: | | [src/calibration/jones.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2NhbGlicmF0aW9uL2pvbmVzLmps) | `0.00% <ø> (-73.77%)` | :arrow_down: | | [src/models/combinators.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL21vZGVscy9jb21iaW5hdG9ycy5qbA==) | `11.90% <ø> (-49.10%)` | :arrow_down: | | [src/models/geometric\_models.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL21vZGVscy9nZW9tZXRyaWNfbW9kZWxzLmps) | `2.63% <0.00%> (-92.30%)` | :arrow_down: | | [src/models/modifiers.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL21vZGVscy9tb2RpZmllcnMuamw=) | `32.59% <ø> (-34.96%)` | :arrow_down: | | [src/models/polarized.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL21vZGVscy9wb2xhcml6ZWQuamw=) | `0.00% <0.00%> (-85.72%)` | :arrow_down: | | [src/rules.jl](https://codecov.io/gh/ptiede/Comrade.jl/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3J1bGVzLmps) | `0.00% <0.00%> (-11.91%)` | :arrow_down: | ... and [24 files with indirect coverage changes](https://codecov.io/gh/ptiede/Comrade.jl/pull/296/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.