search

ptiede / Comrade.jl

MIT License
43 stars 8 forks source link

ur-baselinematrices #317

Closed urirolls5987 closed 1 month ago

urirolls5987 commented 9 months ago

Reorder iteration in gain_schema function

This commit modifies the gain_schema function in jones.jl, altering the iteration order. Previously, the function iterated over time first and then over sites. The function now iterates over sites first and subsequently over time, leading to reordering the design matrix.

ptiede commented 2 months ago

Thanks for working on this. The whole instrument modeling part is being rewritten so the interface to time-baseline ordering is going to change a lot. When the new interface is released we can include priors with different orderings as needed

ptiede commented 1 month ago

@UriRolls I am going to close this since the whole infrastructure has changed. That doesn't mean I want to eliminate this. Rather I'd like us to reimplement something akin to this in the new interface. Also, I think the new interface should make it much easier to include some of your GP based instrument modeling.