codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 93.32322% with 88 lines in your changes are missing coverage. Please review.
Project coverage is 92.55%. Comparing base (
1fe951e) to head (92e06e3).
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #346 +/- ## ========================================== + Coverage 8.55% 92.55% +84.00% ========================================== Files 20 30 +10 Lines 1883 1571 -312 ========================================== + Hits 161 1454 +1293 + Misses 1722 117 -1605 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR will serve as the staging ground for the Comrade instrument modeling refactor. The goal is to completely rewrite how instrument modeling is organized and tremendously simplify the user-facing interface. The new interface will look like it will be broken into three parts:
We also are moving away from design matrices. Instead, the data layout will be managed by a set of arrays of indices that map from site-specific vectors to baseline-specific vectors. This allows me to handle everything much more efficiently and effectively construct the instrument model in a single loop, rather than multiple sparse matrix vector multiplications and broadcasting, which allocated more and did more computation. Additionally, in future releases, we can probably re-organize the data to be maximally cache-friendly due to some abstractions.
TO DO
SiteArrayand add testsSiteArrayChainRulesProjectTofriendlySiteMapfor efficient creation ofSiteArraysArrayConfigurationfrom measurements