ptiede / VIDA.jl

EHT Image domain analysis through template matching.
MIT License
13 stars 4 forks source link

start update to ComradeBase #51

Closed ptiede closed 1 year ago

ptiede commented 2 years ago

Let's interface directly into Comrade so everything just works together nicely. This means stripping out large functionalities since they are repeated in Comrade and are honestly better implementations than VIDA

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.65% and project coverage change: -2.81% :warning:

Comparison is base (e5cb9c2) 93.14% compared to head (2ab7e0a) 90.34%. Report is 14 commits behind head on master.

:exclamation: Current head 2ab7e0a differs from pull request most recent head 3d05e01. Consider uploading reports for the commit 3d05e01 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #51 +/- ## ========================================== - Coverage 93.14% 90.34% -2.81% ========================================== Files 13 11 -2 Lines 1138 497 -641 ========================================== - Hits 1060 449 -611 + Misses 78 48 -30 ``` | [Files Changed](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede) | Coverage Δ | | |---|---|---| | [src/VIDA.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL1ZJREEuamw=) | `60.00% <0.00%> (-40.00%)` | :arrow_down: | | [src/templates/templates.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3RlbXBsYXRlcy90ZW1wbGF0ZXMuamw=) | `25.00% <25.00%> (-75.00%)` | :arrow_down: | | [src/movies.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL21vdmllcy5qbA==) | `68.75% <68.18%> (-31.25%)` | :arrow_down: | | [src/templates/rings.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3RlbXBsYXRlcy9yaW5ncy5qbA==) | `75.60% <75.60%> (ø)` | | | [src/extractor.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2V4dHJhY3Rvci5qbA==) | `87.80% <87.80%> (-7.65%)` | :arrow_down: | | [src/templates/cosinering.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3RlbXBsYXRlcy9jb3NpbmVyaW5nLmps) | `92.59% <92.59%> (ø)` | | | [src/templates/image.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL3RlbXBsYXRlcy9pbWFnZS5qbA==) | `97.29% <95.00%> (+5.27%)` | :arrow_up: | | [src/io.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2lvLmps) | `87.27% <95.83%> (+9.49%)` | :arrow_up: | | [ext/VIDAPlotsExt.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-ZXh0L1ZJREFQbG90c0V4dC5qbA==) | `98.94% <98.94%> (ø)` | | | [src/divergences.jl](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede#diff-c3JjL2RpdmVyZ2VuY2VzLmps) | `100.00% <100.00%> (+5.06%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/ptiede/VIDA.jl/pull/51?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Paul+Tiede) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.