search

ptierno / puppet-windowspagefile

Puppet type and provider to manage windows pagefiles
Other
1 stars 5 forks source link

Deletes weren't working because casing doesn't appear to be consisten… #6

Closed stephenleemcfarland closed 7 years ago

stephenleemcfarland commented 9 years ago

…t. Downcasing name everywhere so we always find the match.

ptierno commented 9 years ago

What version of windows are you using? There is a reason why the name is only being down cased on 2012 nodes. In not sure I understand the purpose of this PR.

stephenleemcfarland commented 9 years ago

I am using 2012 r2. For whatever reason the casing is different between user added, system default, and user edited page files. If you simply ignore case then you won't have to worry about these edge cases. I ran into the issue when I was trying to delete a page file that was previously edited through the windows UI. From the bug reported by someone else a few days ago I'm not the only one. I've forked it so you surely don't need to accept the PR but I think your module will benefit from the modifications I've made.

Stephen M

On Aug 12, 2015, at 1:29 PM, Peter Tierno notifications@github.com wrote:

What version of windows are you using? There is a reason why the name is only being down cased on 2012 nodes. In not sure I understand the purpose of this PR.

― Reply to this email directly or view it on GitHub.

ptierno commented 9 years ago

Thanks for this. I'll run it through some testing and probably merge it in if all is good

On Wed, Aug 12, 2015 at 9:46 PM, slmcfarland81 notifications@github.com wrote:

I am using 2012 r2. For whatever reason the casing is different between user added, system default, and user edited page files. If you simply ignore case then you won't have to worry about these edge cases. I ran into the issue when I was trying to delete a page file that was previously edited through the windows UI. From the bug reported by someone else a few days ago I'm not the only one. I've forked it so you surely don't need to accept the PR but I think your module will benefit from the modifications I've made.

Stephen M

On Aug 12, 2015, at 1:29 PM, Peter Tierno notifications@github.com wrote:

What version of windows are you using? There is a reason why the name is only being down cased on 2012 nodes. In not sure I understand the purpose of this PR.

― Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/ptierno/puppet-windowspagefile/pull/6#issuecomment-130503522 .

TheCraiggers commented 9 years ago

I'm encountering this problem as well, so I can help test this PR too.

TheCraiggers commented 9 years ago

I've did some testing and it at least fixes this specific issue. I don't have a ton of machines to test with yet though, I'm only testing with W2012.

glarizza commented 7 years ago

I tested this branch/code out with a customer, and it's working for me on Windows 2012R2. 👍

TheCraiggers commented 7 years ago

Shit guys, if fucking Gary Larizza says it is good, you should merge it already. :D