search

ptitSeb / Serious-Engine

A port to the OpenPandora (and working fine on plain Linux) of the open source version of a game engine developed by Croteam for the classic Serious Sam games. Status: Working (for both FE and SE).
https://pyra-handheld.com/boards/threads/serious-sam-first-encounter.77225/
GNU General Public License v2.0
74 stars 22 forks source link

Some optimisations #49

Closed iamthesenate1 closed 2 years ago

iamthesenate1 commented 2 years ago

Mostly using initialization lists; some redundant conditions

iamthesenate1 commented 2 years ago

Some files are completely changed. Why?

I don't know... If I check the "Hide whitspace changes" option in the github app everything is normal: screen08 screen09

ptitSeb commented 2 years ago

Thanks :)

iamthesenate1 commented 2 years ago

I have tried to build Serious-Engine using the latest git, but I am getting this error:

[  1%] Built target ecc
[  1%] Generating EntitiesMP/AirShockwave.cpp, EntitiesMP/AirShockwave.h, EntitiesMP/AirShockwave_tables.h
[  1%] Generating EntitiesMP/AmmoPack.cpp, EntitiesMP/AmmoPack.h, EntitiesMP/AmmoPack_tables.h
[  1%] Generating Engine/Classes/PlayerEntity.cpp, Engine/Classes/PlayerEntity.h, Engine/Classes/PlayerEntity_tables.h
[  1%] Generating EntitiesMP/AmmoItem.cpp, EntitiesMP/AmmoItem.h, EntitiesMP/AmmoItem_tables.h
' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AirShockwave.es(14): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AirShockwave.es(15): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AirShockwave.es(17): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AirShockwave.es(18): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AmmoPack.es(14): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AmmoPack.es(15): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AmmoPack.es(16): Error: Unrecognized character '

/home/manjaro/1/Serious-Engine/Sources/Engine/Classes/PlayerEntity.es(7): Error: syntax error
make[2]: *** [CMakeFiles/ParseEntities.dir/build.make:411: Engine/Classes/PlayerEntity.cpp] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/ParseEntities.dir/build.make:433: EntitiesMP/AirShockwave.cpp] Error 1
make[2]: *** [CMakeFiles/ParseEntities.dir/build.make:455: EntitiesMP/AmmoPack.cpp] Error 1
' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AmmoItem.es(14): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AmmoItem.es(15): Error: Unrecognized character '

' (ASCII 0x0d)1/Serious-Engine/Sources/EntitiesMP/AmmoItem.es(16): Error: Unrecognized character '

make[2]: *** [CMakeFiles/ParseEntities.dir/build.make:444: EntitiesMP/AmmoItem.cpp] Error 1
make[1]: *** [CMakeFiles/Makefile2:109: CMakeFiles/ParseEntities.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

@ptitSeb Are you getting the same error? If so, can it be because of a change in this PR?

ptitSeb commented 2 years ago

It looks like some End of Line issue. Are you building on Mac or Windows? Try to convert the .es file to Linux (with dos2linux or something equivalent)

(I don't have any error building on linux)

iamthesenate1 commented 2 years ago

I'm on linux. dos2unix fixed the problem. Thank you very much. Good thing it was just a local problem.

ptitSeb commented 2 years ago

I'll check on GitHub to have the .es files managed as the .c/.cpp files