ptitSeb / box64

Box64 - Linux Userspace x86_64 Emulator with a twist, targeted at ARM64 Linux devices
https://box86.org
MIT License
3.73k stars 267 forks source link

[RV64_DYNAREC] Fixed fpu_flags handling and enabled cosim in CI #1722

Closed ksco closed 1 month ago

ptitSeb commented 1 month ago

Test 6 about threads seems to fail with cosim... or is it random?

ksco commented 1 month ago

Test 6 about threads seems to fail with cosim... or is it random?

It seems random, not sure why, I'll add --repeat until-pass option for now.

ptitSeb commented 1 month ago

Maybe the number of attempt should be limited to 4 or 5? Not sure what's the default is but it needs to trigger if something is actually wrong, and not after a 1/2h wait ;)

ksco commented 1 month ago

Ah ah, it's okay, tests are running pretty fast, and fail pretty fast too, this PR made the CI 2 minutes longer or so ;)