ptitSeb / box86

Box86 - Linux Userspace x86 Emulator with a twist, targeted at ARM Linux devices
https://box86.org
MIT License
3.26k stars 225 forks source link

GoldSource Linux games crashing after a box86 update #559

Closed Raezroth closed 2 years ago

Raezroth commented 2 years ago

So... Gold Source linux games have been crashing for idk how long now. The last revision I can recall it working on was the v0.2.4 release but after Nov 23 commit, which was just an update to the compile readme, I am unsure.

Edit: Forgot to specify, since the latest Steam Runtime update only your latest commit will launch Steam. Since the properties menu on steam is borked (for now) It is nearly impossible to launch only the game with a specific box86 build.

I have forked the repo to shift through the commits to get more familiar with box86 and understand what happened.

Could you by chance look into this as well, please? I've counted 6 gold source games affected by this.

steam.log

WheezyE commented 2 years ago

Hey there! Just to help us narrow down which areas are broken, would you be able to submit specific box86 commits that cause crashes with specific games? (For example, commit aabbcc123 crashes MyGame3 v1.5, using wine 6.1 on TwisterOS, RPi4(x GB) while commits before that don’t cause the crash. Box86log.txt included here) Or some box86 logs of the crashed games?

WheezyE commented 2 years ago

Just a bit more info: From your steam log, it looks like you’re trying to run half-life, but can you submit some output from something like BOX86_LOG=1 box86 halflife.sh or whatever string you use to launch half-life?

Raezroth commented 2 years ago

The steam log provided was from the original half life. I will do the best I can but I am still a noob. Will be back later tonight to work on it

Raezroth commented 2 years ago

I launched from steam mini games list

WheezyE commented 2 years ago

I'm not super sure where your game is installed, but you might try BOX86_LOG=1 ~/.steam/steam/steamapps/common/Half-Life/./hl_linux and see if that runs half life directly and gives you any box86 logging output

Raezroth commented 2 years ago

I have tried different ways of launching it. I found that the changes on Nov 30 have caused this regression.

I added ptitSeb's dprintf fix to different commits so steam launches on them, I found that 11/29/2021 build (my fork of it with the steam patch https://github.com/Raezroth/box86/tree/GoldSrc-Working) is launching gold source games. LOG HERE: hlworking.log

The build from 11/30/2021 (my fork wit

h the steam patch https://github.com/Raezroth/box86/tree/Test) however does not launch gold source games. Same output as previous steam log provided steam.log

I will revert those commits in a different branch and hope it doesn't break any of the later commits. Again Total Noob.

ptitSeb commented 2 years ago

Mmmm, so elfloader changes? There are 3 commit on 30th of november. I assume the regression was with 4e2f50eee7f9de7227a6986ead1b88f18deb9b89 ? And the fix from dec. 19th is not enough for GoldSrc?

ptitSeb commented 2 years ago

It should be fixed now, using latest version. Can you check?

Raezroth commented 2 years ago

Yes, It actually did, thank you!! I passed out working on this last night, to find it fixed after waking up. ptit, you a champ.

Raezroth commented 2 years ago

I am deleting my fork till I run into another issue needing testting and fixing