search

ptitSeb / box86

Box86 - Linux Userspace x86 Emulator with a twist, targeted at ARM Linux devices
https://box86.org
MIT License
3.37k stars 233 forks source link

License file headers missing #748

Open AndreRH opened 1 year ago

AndreRH commented 1 year ago

Hi, I consider reusing box86 files in other projects (e.g. hangover or wine). Likely box86 before box64 (see https://github.com/ptitSeb/box64/issues/484) Would someone mind to add the license headers or at least spdx identifiers to all the source files?

ptitSeb commented 1 year ago

I'm unsure, what would you want the files to have for header? licence is MIT.

AndreRH commented 1 year ago

Maybe the spdx identifier + the copyright, or the full license text including the copyright. MIT is permissive, but taking a single file out of this repo might be tricky. Nobody should mess with license stuff except the (main-)author.

LukeShortCloud commented 3 weeks ago

@AndreRH Is this still relevant for helping you with Hangover integration? If so, does this meet your minimum requirement?

/*
 * Copyright (C) 2024 Sébastien Chevalier
 * MIT
*/
AndreRH commented 3 weeks ago

Hi, it's less relevant for me as I solved it differently, and I'm not using Box86, but Box64 instead.

Other than that I think it would be good to have it like here: https://github.com/intel/RealTimePathTracingResearchFramework/blob/d8c190b3645f8b8a80035f03c305beeefb94f87b/pch.hpp#L4 SPDX-License-Identifier: MIT