Question about skips.h and #define guards

ptitSeb / gl4es

GL4ES is a OpenGL 2.1/1.5 to GL ES 2.0/1.1 translation library, with support for Pandora, ODroid, OrangePI, CHIP, Raspberry PI, Android, Emscripten and AmigaOS4.

http://ptitseb.github.io/gl4es/

MIT License

694 stars 159 forks source link

Question about skips.h and #define guards #434

Closed Mathias-Boulay closed 1 year ago

Mathias-Boulay commented 1 year ago

Hello there, something has been troubling me with the file src/gl/wrap/skips.h. It allows to redefine functions by versions that call directly the underlying OGLES implementation. However, enabling the direct pass-through results in the gl4es_ version being redefined.

Is this an oversight ? I have a feeling enabling the direct pass-through should disable (read undefine) the normal gl4es_ implementation

ptitSeb commented 1 year ago

gl4es_XXX implementation are needed for the glXGetProcAddress(...) function. For all the new function, I usualy don't use direct mapping anyway. It's a legacy mecanism, and skipping all the state tracking is usualy not a good idea.

Mathias-Boulay commented 1 year ago

That's fair.