search

ptmcg / logmerger

TUI utility to view multiple log files with merged timeline
MIT License
145 stars 3 forks source link

Cannot import name 'Never' from 'typing' #33

Closed hdemers closed 7 months ago

hdemers commented 9 months ago

This seems like a very interesting tool. However, I immediately get the following error upon running the CLI:

Traceback (most recent call last):
  File "/home/-----/.local/bin/logmerger", line 5, in <module>
    from logmerger.logmerger import main
  File "/home/------/.local/pipx/venvs/logmerger/lib/python3.10/site-packages/logmerger/logmerger.py", line 16, in <module>
    from typing import TypeVar, Never
ImportError: cannot import name 'Never' from 'typing' (/usr/lib/python3.10/typing.py)

This is because I'm using Python 3.10 and Never was introduced in 3.11.

Maybe specify python_requires= >=3.11 or use NoReturn (my preference to the latter).

Thanks.

ptmcg commented 9 months ago

Nice catch, thank you! I think I'd actually like to maintain support back to 3.9, so I'll clean up a few other typing usages too.

ptmcg commented 7 months ago

Fixed in 0.8.0