search

ptmt / react-native-macos

[deprecated in favor of https://microsoft.github.io/react-native-windows/] React Native for macOS is an experimental fork for writing desktop apps using Cocoa
MIT License
11.25k stars 429 forks source link

password prop passed to TextInput gets ignored by component #188

Closed jariz closed 5 years ago

jariz commented 6 years ago

Description

The TextField var gets declared, but the TextInput always uses RCTTextView instead. I'm not entirely sure how it's possible that this is not a problem for the UIExplorer app, however. I can not get the text input to display as a secure text entry without modifying TextInput to use TextField over RCTTextField.

Reproduction Steps and Sample Code

<TextInput password />

Solution

Use the TextField variable. I can open a PR, I'm just wondering how it's possible that the UIExplorer does work. Can you confirm if am I still doing something wrong somehow?

Additional Information

aleclarson commented 5 years ago

Please provide a sample repo that can reproduce this issue. Thanks!

jariz commented 5 years ago

@aleclarson Have you tried the sample code? If it's not showing up for you anymore, then I'm guessing it's fixed now.

aleclarson commented 5 years ago

@jariz Password inputs are working in RNTester, so I'll need a sample repo with the exact setup you were using when you encountered this bug. If you can't reproduce with the latest version, let me know! Until then, I'm going to close this. ❤️