Upgrading metro to v0.45.2

aleclarson commented 5 years ago

Hey, I've been working on upgrading the metro dependency from v0.24.3 to v0.45.2 (which is a version I've recently added symlink support to).

I think you'll find my commits useful, but many of them depend on improvements I've made to metro and jest-haste-map which are not yet merged.

Here's the list of the commits you can cherry-pick without upgrading metro or anything:

baec9025ed41ed80876dd25ac999a9c4271fb4df fix: add jest/hasteImpl.js
06e66bb658edff30e6f5a2edd695f9ff76ae59f4 Add support for out-of-tree platform plugins (#20825)
c7bbfe6f02ee837f5fb7e61e81d348b9dd8425f2 feat: inject "macos" platform automatically
74d1d818bf83fa2ec84f21fc10e8de695e4f790f Pass the maxWorkers config param correctly to Metro
759be096ba486b3f32e2499d19e9edcaa9dd314a fix: "react" peer dependency
c352cc103789840fe8c30b85bce4d7255d9658c2 fix: "Duplicate declaration" transform error
641309d9f5828f9b28e6ffca2664569d979fae6b fix: "optional rest parameters" eslint error

Side note: None of the above are related to upgrading Metro. I just fixed these as I was upgrading.

Commits 1 thru 3 are my favorite, because they let you omit the platforms and providesModuleNodeModules properties from your metro.config.js module.

But commit 4 is really nice too, since it fixes some config options that were being overwritten by defaults.

aleclarson commented 5 years ago

If you want, I can send a PR with all of these. :)

ptmt commented 5 years ago

Would be awesome! On Wed, 26 Dec 2018 at 01:06, Alec Larson notifications@github.com wrote:

If you want, I can send a PR with all of these. :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ptmt/react-native-macos/issues/217#issuecomment-449876138, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9SU6jdWpIgWdejOyz4GWzzmZujvbx2ks5u8qFTgaJpZM4ZhOfo .

ptmt / react-native-macos

Upgrading metro to v0.45.2 #217