More RCTRedBox improvements

[aleclarson]

• fix: RCTRedBox#copyStack

  • use NSPasteboard correctly
  • avoid truncating the error message too early
  • avoid overwriting the first error with another error (regression from v0.18.3)
  • trim whitespace in error message
  • fix measurement of error message  

• fix: detect circular refs in bridge messages

  • also, stringify invalid messages for easier debugging  

• fix: catch invalid native calls from JS

  • This allows RCTRedBox to show when JS tries to send an invalid native call over the bridge. Without this commit, you need to check the Xcode logs to know what happened.  

• fix: re-enable redBox in _RCTLogNativeInternal

  • This commented-out line was preventing RCTRedBox from appearing for certain errors (eg: failed to load bundle)  

• fix: "Failed to load bundle" error

  • Improved readability by adding in some line breaks  

• fix: filter out stack frames with no filename

  • These stack frames show up as empty cells in the table view, so just remove them. I checked all references to _lastStackTrace to make sure I didn't break anything.  

• fix: ensure native stack frame has an absolute file path

• fix: avoid calling deselectRow with -1

[aleclarson]

Please wait on merging this. I have one more fix to do! 😄

edit: Okay, ready! 👍

[ptmt]

I added you as a collaborator, feel free to merge it to master! :)

[aleclarson]

@ptmt I can help out with publishing to NPM too, if you want! 🤓👍

[ptmt]

Thanks again! Published to the NPM this time, but I'll check out npm documentation about my options to do it right.

On Sun, 27 Jan 2019 at 18:10 Alec Larson notifications@github.com wrote:

@ptmt https://github.com/ptmt I can help out with publishing to NPM too, if you want! 🤓👍

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ptmt/react-native-macos/pull/224#issuecomment-457925812, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9SU3MJe6oJFPwf5Otj60XqAOvTDIIVks5vHcGAgaJpZM4aUWwV .

[aleclarson]

Looks like you published v0.19.0 instead of v0.18.4. Was that on purpose?

Anyway, I corrected the master branch to reflect this. 👍

[ptmt]

Yes, previously all even versions were attached to RN ones (big merge), and odd for minor improvements once in a while. So 0.19.x in celebration of new contributor :)

On Sun, 27 Jan 2019 at 20:04, Alec Larson notifications@github.com wrote:

Looks like you published v0.19.0 instead of v0.18.4. Was that on purpose?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ptmt/react-native-macos/pull/224#issuecomment-457935392, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9SU0xJGO11pCgHSvs1IXwFOriL5Zylks5vHdwogaJpZM4aUWwV .