search

ptmt / react-native-macos

[deprecated in favor of https://microsoft.github.io/react-native-windows/] React Native for macOS is an experimental fork for writing desktop apps using Cocoa
MIT License
11.25k stars 429 forks source link

feat: upgrade React to v16.6.3 #225

Open aleclarson opened 5 years ago

aleclarson commented 5 years ago

This PR provides support for the React version used by React Native v0.58.3 (the current version at time of writing). I've done some thorough testing in the RNTester, but it would be great if some other people could test this PR on their own apps and provide feedback.

Note: This PR does not include any new native features, so there are plenty of react-native commits that still need to be ported over. I plan to make React hooks work inside react-native-macos in a future PR, so that's why this PR was created.

ptmt commented 5 years ago

Will be able to try to test on couple apps later this week On Tue, 29 Jan 2019 at 07:15, Alec Larson notifications@github.com wrote:

This PR provides support for the React version used by React Native v0.58.3 (the current version at time of writing). I've done some thorough testing in the RNTester, but it would be great if some other people could test this PR on their own apps and provide feedback.

Note: This PR does not include any new native features, so there are plenty of react-native commits that still need to be ported over. I plan to make React hooks https://reactjs.org/docs/hooks-intro.html work inside react-native-macos in a future PR, so that's why this PR was created.

You can view, comment on, or merge this pull request online at:

https://github.com/ptmt/react-native-macos/pull/225 Commit Summary

  • feat: upgrade React to v16.6.3
  • Log query name for fetchRelayQuery
  • RN: Remove React Stack Systrace Logic
  • Move TouchHistoryMath from React Repo to React Native
  • Move takeSnapshot from React repo to RN
  • fix: delete ReactNativePropRegistry
  • fix: stop using ReactNativeComponentTree
  • fix: stop using ReactNativeBridgeEventPlugin
  • throw when exists in
  • fix: remove unused Renderer shims
  • fix: add @providesModule to updated Renderer shims

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ptmt/react-native-macos/pull/225, or mute the thread https://github.com/notifications/unsubscribe-auth/AA9SUy-XunKxwHyFI2YBQVaBnWp9SpX0ks5vH8rHgaJpZM4aXQ4R .

ptmt commented 5 years ago

Using aleclarson/react-native-macos#alpha I got the new error window with a little bit broken layout around buttons. Plus maybe a bit around font size and padding or is it intended?

screenshot 2019-01-29 21 26 59

Regarding the error itself, I think I might overlook something related to metro bundler, need some time to investigate. The repo is here https://github.com/16ms/videotape

ptmt commented 5 years ago

Thanks again for your work!