search

ptomasroos / react-native-scrollable-tab-view

Tabbed navigation that you can swipe between, each tab can have its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar
https://www.npmjs.com/package/react-native-scrollable-tab-view
6.93k stars 2.29k forks source link

Cannot install package with the latest upgrade commit #1154

Open solomonik07 opened 2 years ago

solomonik07 commented 2 years ago
Screenshot 2021-09-01 at 00 07 56

I have an error with getNode() method. This method was removed from the library, but I still get it when I install the package (using yarn).

Link to the merged commit: https://github.com/ptomasroos/react-native-scrollable-tab-view/compare/v1.0.0...master

Can anyone please help me get the latest version of the package?

nthegedus commented 2 years ago

Same issue here. This error started after upgrade react-native to 0.65.1

@solomonik07 and for those who have the same problem, update your package.json from this:

"react-native-scrollable-tab-view": "1.0.0"

to this: "react-native-scrollable-tab-view": "git+git@github.com:ptomasroos/react-native-scrollable-tab-view.git"

nthegedus commented 2 years ago

Just an update, I was testing on Android and got a crash caused by ViewPager, and I found a solution made by @frankfancode https://github.com/ptomasroos/react-native-scrollable-tab-view/pull/1150

So now I'm using this like this: "react-native-scrollable-tab-view": "git+git@github.com:frankfancode/react-native-scrollable-tab-view.git"

yasodha-r commented 2 years ago

@nthegedus thanks for update, it fixed the ViewPager crash but if tabs are wrapped in scrollview it is not showing up the tab pager. Works well if it is not in the scrollview.