search

ptomasroos / react-native-scrollable-tab-view

Tabbed navigation that you can swipe between, each tab can have its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar
https://www.npmjs.com/package/react-native-scrollable-tab-view
6.93k stars 2.29k forks source link

Fix deprecated prop types #1185

Closed alistairholt closed 1 year ago

alistairholt commented 1 year ago

ViewPropTyes and TextPropTypes have been removed from React Native. This migrates to deprecated-react-native-prop-types.

luluhoc commented 1 year ago

@ptomasroos please merge

alistairholt commented 1 year ago

@ptomasroos please?

nickolasmdasilva commented 1 year ago

Will you merge it @ptomasroos?

ptomasroos commented 1 year ago

View pager has been updated in this pull request

would be great if someone could test the branch before I merge

alistairholt commented 1 year ago

@ptomasroos I've been using these fixes in production for a while now and everything has been fine. Not sure why @react-native-community/viewpager changed here… it seems that yarn.lock must have been out-of-date because package.json has had 3.3.0 specified for @react-native-community/viewpager for 3 years (see https://github.com/ptomasroos/react-native-scrollable-tab-view/pull/1067)

ptomasroos commented 1 year ago

Thanks for the fix @alistairholt and taking the time to comment

alistairholt commented 1 year ago

@ptomasroos thank you!

arlovip commented 1 year ago

Please release a new version to support the latest version like 0.70.6. Thank you.