ptomasroos / react-native-scrollable-tab-view

Tabbed navigation that you can swipe between, each tab can have its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar
https://www.npmjs.com/package/react-native-scrollable-tab-view
6.93k stars 2.29k forks source link

ViewPropTypes will be removed from React Native #1186

Closed SmileYang966 closed 1 year ago

SmileYang966 commented 1 year ago

Issue1 : ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types

solution:

  1. yarn add deprecated-react-native-prop-types
  2. We have to modify the source code, open every js source file, and do the following replacment import {ViewPropTypes} from 'deprecated-react-native-prop-types'; or not const { ViewPropTypes } = ReactNative = require('react-native');

Issue2: TypeError: undefined is not an object (evaluating '_reactNative.Text.propTypes.style') const ScrollableTabBar = createReactClass({ propTypes: { goToPage: PropTypes.func, activeTab: PropTypes.number, tabs: PropTypes.array, backgroundColor: PropTypes.string, activeTextColor: PropTypes.string, inactiveTextColor: PropTypes.string, scrollOffset: PropTypes.number, style: ViewPropTypes.style, tabStyle: ViewPropTypes.style, tabsContainerStyle: ViewPropTypes.style, textStyle: Text.propTypes.style, renderTab: PropTypes.func, underlineStyle: ViewPropTypes.style, onScroll: PropTypes.func, },

textStyle: Text.propTypes.style ,I just choose to replace it by 'textStyle: ViewPropTypes.style', it work and the error was gone You might need to change this in many source files.

Issue3: ScrollView.getNode is undefined

We need to find the source code in react-native-scrollable-tab-view folder, this.scrollView.getNode().scrollTo change to this.scrollView.scrollTo, just remove the getNode() , error was gone.

Hope it can help you.

biaji commented 1 year ago

Text.propTypes.style,

should be replaced by:

const { TextPropTypes } = require('deprecated-react-native-prop-types');

ptomasroos commented 1 year ago

This has been resolved with #1185