search

ptomasroos / react-native-scrollable-tab-view

Tabbed navigation that you can swipe between, each tab can have its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar
https://www.npmjs.com/package/react-native-scrollable-tab-view
6.94k stars 2.28k forks source link

FacebookTabBar example errors #22

Closed mutp closed 8 years ago

mutp commented 9 years ago

Hey first of all great repo!

I am facing an issue integrating the FacebookTabBar example. I get the error "icon.setNativeProps is not a function " in the function

setAnimationValue(value) { var currentPage = this.props.activeTab;

this.unselectedTabIcons.forEach((icon, i) => {
  if (value - i >= 0 && value - i <= 1) {
    icon.setNativeProps({opacity: value - i});
  }
  if (i - value >= 0 &&  i - value <= 1) {
    icon.setNativeProps({opacity: i - value});
  }
});

},

Also, if I do a console.log(icon), it says icon is not defined I had no problem integrating the CustomTabBar code. Thanks again!

brentvatne commented 9 years ago

hi there, not really sure what's going on with this one, maybe something has changed with a dependency, if you have a chance to investigate and fix a PR would be much appreciated!

apolkingg8 commented 9 years ago

Same issue with that, fixed with #40.