ptomasroos / react-native-scrollable-tab-view

Tabbed navigation that you can swipe between, each tab can have its own ScrollView and maintain its own scroll position between swipes. Pleasantly animated. Customizable tab bar
https://www.npmjs.com/package/react-native-scrollable-tab-view
6.94k stars 2.28k forks source link

None of the props work for me, except of renderTabBar #74

Closed BigPun86 closed 8 years ago

BigPun86 commented 9 years ago

I am trying to use especially the locked props, so the only way to switch between the tabs is by tabbing the tabs. But unfortunately the only props which works is the renderTabBar prop.

  <ScrollableTabView
            locked={true}
            ..........tried all other props
            renderTabBar={() => <CustomTabBar someProp={'here'}/>}>
            <View style={styles.tabView} tabLabel="Tab1">
                <SomeView1 />
            </View>
            <View style={styles.tabView} tabLabel="Tab2">
                <SomeView2 />
            </View>
  </ScrollableTabView>

Did anybody face the same problem?

sulliwane commented 8 years ago

I have the same problem, adding "locked={true}" do not lock the scrolling, and I can't find any mention of this prop into the code. Is it deprecated? Or any idea why this prop is not working? Thank you.

brentvatne commented 8 years ago

Are you on Android? @sulliwane

brentvatne commented 8 years ago

This could be broken since we use ScrollView / ViewPagerAndroid now, cc @skv-headless

sulliwane commented 8 years ago

@brentvatne yes I'm on Android (and ios), same problem. I just looked at the code, and most of the props are not used anymore. I will PR after ensuring the modifications is cross platform.

skv-headless commented 8 years ago

mini roadmap

I can do it on this week but not sure exactly when. @sulliwane if you do it would be awesome.

sulliwane commented 8 years ago

@skv-headless thanks!!