search

ptomasroos / react-native-tab-navigator

A tab bar that switches between scenes, written in JS for cross-platform support
MIT License
2.4k stars 416 forks source link

Migrate deprecated React.PropTypes and View.propTypes #152

Closed alphasp closed 7 years ago

alphasp commented 7 years ago

fix #145, backward compatible with older version

abdurrahmanekr commented 7 years ago

Is the issue still ongoing? Does this resolve the PR problem? if resolve, please merge.

iRoachie commented 7 years ago

@ptomasroos Is everything good here?

mgenov commented 7 years ago

Looks replicated with #156. It would be nice if either of them is merged as this could fix integration with 16.x versions of react.

ptomasroos commented 7 years ago

Hey ! I will handle review it tomorrow since I've been off for vacation, sorry for delay.

ptomasroos commented 7 years ago

Thanks for this, didnt know about the backwards compatible way.

iRoachie commented 7 years ago

@ptomasroos As soon as you can merge this let me know. Currently, right now it's breaking react-native-elements. I'll switch to use master for the time being

ptomasroos commented 7 years ago

It's already merged @iroachie

iRoachie commented 7 years ago

Yea it's merged, but you didn't publish a new version to npm

ptomasroos commented 7 years ago

0.3.4 is now released @iRoachie

iRoachie commented 7 years ago

Thanks!