Refactored to use PropTypes from 'prop-types' - Githubissues

ptomasroos / react-native-tab-navigator

A tab bar that switches between scenes, written in JS for cross-platform support

MIT License

2.4k stars 416 forks source link

Refactored to use PropTypes from 'prop-types' #156

Closed jasonnathan closed 7 years ago

jasonnathan commented 7 years ago

What does this PR do?

Package was throwing warnings in tests (not used directly but via react-native-elements) in React@16

Where should the reviewer start?

Simply changed references in all JS files and added prop-types as a dependancy

How should this be manually tested?

All existing tests should run,

Who should be notified?

[ ] Write down the name/department this branch needs
[ ] to be communicated to
[ ] Check the box(es) to indicate that it has been
[ ] communicated (add the label)

What should happen on deployment? (check all that apply)

[x] The usual steps.
[ ] There are database changes, which should be run.
[ ] There are files that should be manually uploaded.

Questions:

Does this require a blog post?
Does this require a knowledge base update?
Does support need training for this?
Does this has to be communicated to partners?

ptomasroos commented 7 years ago

This for the great work, it has already been merged in #152