search

ptomasroos / react-native-tab-navigator

A tab bar that switches between scenes, written in JS for cross-platform support
MIT License
2.4k stars 415 forks source link

Allow font scaling #38

Closed GantMan closed 8 years ago

GantMan commented 8 years ago

allowFontScaling passed down to tab React.Text components. See image example with accessibility text turned up to the max.

Before

screen shot 2015-12-25 at 8 42 27 pm

Aftert - with allowFontScaling={false}

image

ide commented 8 years ago

Could you actually make it so that fontScaling is off by default? I didn't realize how clowny the tab bar looks with scaling on most of the time.

GantMan commented 8 years ago

Well, what I posted was worst case scenario. See this image for full scale of options provided by apple: image

I'd recommend it be on by default, since most people won't fall in "worst case". If you still dislike this, I'll change it. I'm just happy to have access/control to it.

ide commented 8 years ago

On iOS 9, changing the font scaling setting doesn't change the tab bar text size so I think it's fine to have scaling off by default (and it's awesome that RN + custom components lets us enable scaling if wanted).

GantMan commented 8 years ago

updated :+1: