ptomasroos / react-native-tab-navigator

A tab bar that switches between scenes, written in JS for cross-platform support
MIT License
2.4k stars 415 forks source link

New features (Vectorial-Icons, NativeButton, Scrollable) and some fix (tintColor, paddingBottom, alignItems) #61

Closed magrinj closed 8 years ago

magrinj commented 8 years ago

Fix:

New features:

Hope that can help!

ide commented 8 years ago

There are too many dependencies and features in this PR that the maintainers of this component won't use. Instead we should make it so that you can write your own code and inject it in.

magrinj commented 8 years ago

Ok I understand, but for some feature I'm not sure if it's the right way, like for vectorial-icons, I follow the props of the official component for iOS. You can just select the stuff you want in my commits, and don't take the thing you don't want, by example the padding bottom if not title is a recurrent error. I can try to make something more customizable, but I've a lot of work, maybe in few days or months :)

code-smith commented 8 years ago

why is the latest code not updated yet?

ide commented 8 years ago

@code-smith We take PRs that add features we use and can maintain. If you would like to use this code then you probably should use a fork.

magrinj commented 8 years ago

So @ide, when you say you can write your own code and inject it in, I don't really understand ? What do you mean by injecting my code ?

ide commented 8 years ago

Say you want to use react-native-vector-icon, for example. Instead of adding react-native-vector-icon to the TabNavigator, you would inject your code by writing:

<TabNavigator.Item
  renderIcon={() => <Icon name="star" size={30} color="#900" />}
/>
magrinj commented 8 years ago

Oh ok I understand, thanks! I will do that in few days if I have time :)