Closed magrinj closed 8 years ago
There are too many dependencies and features in this PR that the maintainers of this component won't use. Instead we should make it so that you can write your own code and inject it in.
Ok I understand, but for some feature I'm not sure if it's the right way, like for vectorial-icons, I follow the props of the official component for iOS. You can just select the stuff you want in my commits, and don't take the thing you don't want, by example the padding bottom if not title is a recurrent error. I can try to make something more customizable, but I've a lot of work, maybe in few days or months :)
why is the latest code not updated yet?
@code-smith We take PRs that add features we use and can maintain. If you would like to use this code then you probably should use a fork.
So @ide, when you say you can write your own code and inject it in
, I don't really understand ? What do you mean by injecting my code ?
Say you want to use react-native-vector-icon
, for example. Instead of adding react-native-vector-icon
to the TabNavigator, you would inject your code by writing:
<TabNavigator.Item
renderIcon={() => <Icon name="star" size={30} color="#900" />}
/>
Oh ok I understand, thanks! I will do that in few days if I have time :)
Fix:
New features:
NativeButton
class, useTouchableOpacity
for iOS andTouchableNativeFeedback
for Androidstyle
andselectedStyle
propsreact-native-vector-icon
library, allow user to set a vectorial icon withiconName
,iconSize
,iconColor
andiconSelectedColor
propsscrollEnabled
propsHope that can help!