YAML file generated is incorrect

ptorr-msft / WinGetYamlGenerator

Simple GUI editor for creating YAML files for WinGet.

MIT License

61 stars 19 forks source link

YAML file generated is incorrect #31

Open aavdberg opened 3 years ago

aavdberg commented 3 years ago

When i generate a YAML file the syntax of the file is incorrect.

Switches have to be following syntax

Switches:
  Silent: /s
  SilentWithProgress: /

To get no warning like:

Manifest validation succeeded with warnings. Manifest Warning: Silent and SilentWithProgress switches are not specified for InstallerType exe. Please make sure the installer can run unattended.

ptorr-msft commented 3 years ago

Can you share the YAML file you generated, and a screenshot of how you set it in the app? The manifest docs say the strings are arbitrary and defined by the installer; WinGetYamlGenerator doesn't try to validate them at all.

aavdberg commented 3 years ago

En this how i changed it so that i don't get error

ptorr-msft commented 3 years ago

OK thanks - so if you have one of them then you need both of them? Is that the problem?

aavdberg commented 3 years ago

Yes indeed

Switches: Silent: /s

only will give the following warning.

s-crypt commented 3 years ago

Not necessarialy, but Silent now needs to be a sub option of Switches according to the new spec.

Switches:
  Silent: /s

Regarding the new spec and the new options that come with it, I think the UI should be updated to reflect those changes. Updating all of this may not be needed as a CLI is being created for submitting packages that might include those options.

ptorr-msft commented 3 years ago

I need to update for the new schema.. will look into it this week[end] hopefully.