search

ptrLx / OneShot

Remember the happy days!
GNU General Public License v3.0
41 stars 3 forks source link

Translation: German #15

Open BuddyHoli opened 1 year ago

BuddyHoli commented 1 year ago

Love this App. Just send me the phrases and I will do my best to send the German translation back. Amazing work.

ptrLx commented 1 year ago

Thank's! Some refactoring needs to be done to enable multiple languages as all Strings are hard-coded currently :/

BuddyHoli commented 1 year ago

No problem. Ready when you are ;)

ptrLx @.***> schrieb am Mo., 20. März 2023, 10:38:

Thank's! Some refactoring needs to be done to enable multiple languages as all Strings are hard-coded currently :/

— Reply to this email directly, view it on GitHub https://github.com/ptrLx/OneShot/issues/15#issuecomment-1475901936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKLMWZ7R7WI2MH5V36PHVC3W5AQQRANCNFSM6AAAAAAWAJTZSA . You are receiving this because you authored the thread.Message ID: @.***>

ptrLx commented 1 year ago

I have extracted most strings now and added German translation myself.

Feel free to have a look: https://github.com/ptrLx/OneShot/blob/dev/app/src/main/res/values-de/strings.xml

BuddyHoli commented 1 year ago

That looks pretty good. Are you German? Translation is flawless.

ptrLx @.***> schrieb am Mi., 22. März 2023, 00:08:

I have extracted most strings now and added German translation myself.

Feel free to have a look: https://github.com/ptrLx/OneShot/blob/dev/app/src/main/res/values-de/strings.xml

— Reply to this email directly, view it on GitHub https://github.com/ptrLx/OneShot/issues/15#issuecomment-1478710528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKLMWZ6DWZGWL56DG7I3ZFTW5IYGHANCNFSM6AAAAAAWAJTZSA . You are receiving this because you authored the thread.Message ID: @.***>

ptrLx commented 1 year ago

Great, translation will be available in the next release.

Are you German? Yes :)

OddSobriquet commented 1 year ago

Hi :)

Line 41 there's a typo possibly due to a change of phrasing, I would also suggest re-arranging the sentence a bit.

This is just a suggestion, though.

<string name="privacy_text">Deine Daten sind deine! OneShot wird niemals Daten an irgendwelche Server senden, solange du dem nicht zustimmst. Aktuell benötigt die App keine Internetberechtigung.</string>

Alternatively, if you plan to keep it as an offline-only-app you might even drop the Zustimmung / Einwilligung part.

ptrLx commented 1 year ago

I was thinking of integrating an API for motivation slogans originally. One could accept the slogan to be added to the entry or even apply a custom one. But I don't have time for that and I'm not sure if users would like that feature (for privacy reasons).

That's why I want to leave this (currently useless) "opt-in" notice.

OddSobriquet commented 1 year ago

Ah, gotcha. Jo, verstehe ich 😊