Closed WesleyRosenblum closed 2 years ago
Hi Wesley, Thanks for you feedback. Connection-id functionality is not yet implemented in the server, and not at all tested by me, so i'm sure it will be flaky. Also, i think the client implementation needs an overhaul, i planned to do these things at the same time, as there will be a lot of shared functionality. That is also the reason why i haven't picked op #13 yet. Currently, i'm working on server session resumption and zero-rtt. When that's done, i think i should pick-up the connection id stuff, to ensure both implementations are at least conforming to specification.
For server role, this should now be fixed by https://bitbucket.org/pjtr/kwik/commits/b8fb5b14a6a9a07e229dc98ee62a443de6fff70b?at=connection-ids. Will merge to master after client role is fixed too.
Now also merged to master.
When testing kwik server, after sending
NEW_CONNECTION_ID
frames requesting the retirement of the connection ID used during the handshake (sequence number 0), we are not receiving aRETIRE_CONNECTION_ID
frame.For example, when a client sends this frame to kwik:
kwik should transmit a
RETIRE_CONNECTION_ID
frame with Sequence: 0, but it does not always do this. In some cases it does not send theRETIRE_CONNECTION_ID
frame at all, in other cases it sends an invalidRETIRE_CONNECTION_ID
frame, see https://github.com/ptrd/kwik/issues/13.Thanks for considering this issue and let me know if you need any further information!