search

pts / sam2p

raster (bitmap) image converter with smart PDF and PostScript (EPS) output
http://pts.50.hu/sam2p/
GNU General Public License v2.0
42 stars 15 forks source link

heap buffer overflow in input-bmp.ci:311 #56

Closed puppet-meteor closed 5 years ago

puppet-meteor commented 5 years ago

There is a heap buffer overflow in input-bmp.ci:311 at sam2p 0.49.4. A crafted input will lead to denial of service attack.

Steps to Reproduce:

./sam2p POC_5 EPS: /dev/null

POC File: https://github.com/puppet-meteor/sam2p_POC/blob/master/POC_5

Information from addresssanitizer:

This is sam2p 0.49.4.
Available Loaders: PS PDF JAI PNG JPEG TIFF PNM BMP GIF LBM XPM PCX TGA.
Available Appliers: XWD Meta Empty BMP PNG TIFF6 TIFF6-JAI JPEG-JAI JPEG PNM GIF89a+LZW XPM PSL1C PSL23+PDF PSL2+PDF-JAI P-TrOpBb.
=================================================================
==6701==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61e00000e450 at pc 0x000000428072 bp 0x7ffcd4f89d20 sp 0x7ffcd4f89d10
WRITE of size 1 at 0x61e00000e450 thread T0
    #0 0x428071 in ReadImage /home/puppet/target/sam2p-gdb/input-bmp.ci:311
    #1 0x428071 in bmp_load_image(_IO_FILE*) /home/puppet/target/sam2p-gdb/input-bmp.ci:206
    #2 0x42823c in in_bmp_reader /home/puppet/target/sam2p-gdb/in_bmp.cpp:23
    #3 0x478f1b in Image::load(Image::Loader::UFD*, SimBuffer::Flat const&, char const*) /home/puppet/target/sam2p-gdb/image.cpp:1427
    #4 0x403a96 in run_sam2p_engine(Files::FILEW&, Files::FILEW&, char const* const*, bool) /home/puppet/target/sam2p-gdb/sam2p_main.cpp:1024
    #5 0x40264f in main /home/puppet/target/sam2p-gdb/sam2p_main.cpp:1117
    #6 0x7fc51aae382f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #7 0x402f98 in _start (/usr/local/bin/sam2p+0x402f98)

0x61e00000e450 is located 48 bytes to the left of 2880-byte region [0x61e00000e480,0x61e00000efc0)
allocated by thread T0 here:
    #0 0x7fc51af25602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x41f2aa in emulate_cc_new /home/puppet/target/sam2p-gdb/c_lgcc.cpp:35
    #2 0x41f2aa in operator new[](unsigned long) /home/puppet/target/sam2p-gdb/c_lgcc.cpp:55
    #3 0x4279a2 in ReadImage /home/puppet/target/sam2p-gdb/input-bmp.ci:267
    #4 0x4279a2 in bmp_load_image(_IO_FILE*) /home/puppet/target/sam2p-gdb/input-bmp.ci:206
    #5 0x42823c in in_bmp_reader /home/puppet/target/sam2p-gdb/in_bmp.cpp:23
    #6 0x478f1b in Image::load(Image::Loader::UFD*, SimBuffer::Flat const&, char const*) /home/puppet/target/sam2p-gdb/image.cpp:1427
    #7 0x403a96 in run_sam2p_engine(Files::FILEW&, Files::FILEW&, char const* const*, bool) /home/puppet/target/sam2p-gdb/sam2p_main.cpp:1024
    #8 0x40264f in main /home/puppet/target/sam2p-gdb/sam2p_main.cpp:1117
    #9 0x7fc51aae382f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

SUMMARY: AddressSanitizer: heap-buffer-overflow /home/puppet/target/sam2p-gdb/input-bmp.ci:311 ReadImage
Shadow bytes around the buggy address:
  0x0c3c7fff9c30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c3c7fff9c40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c3c7fff9c50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c3c7fff9c60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c3c7fff9c70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x0c3c7fff9c80: fa fa fa fa fa fa fa fa fa fa[fa]fa fa fa fa fa
  0x0c3c7fff9c90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c3c7fff9ca0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c3c7fff9cb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c3c7fff9cc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c3c7fff9cd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
==6701==ABORTING

found by puppet@zju.edu.cn from NESA Lab in Zhejiang University.

pts commented 5 years ago

Thank you for reporting this! I'm not able to reproduce this bug with the latest sam2p HEAD (d2656beef486c55b53ae0d7e395d6610cc8ee744), so I'm closing this issue now. Feel free to report more issues, but please check that you have d2656beef486c55b53ae0d7e395d6610cc8ee744 or later checked out.

$ ./sam2p.asan POC_5 EPS: /dev/null
This is sam2p 0.49.4.
Available Loaders: PS PDF JAI PNG JPEG TIFF PNM BMP GIF LBM XPM PCX TGA.
Available Appliers: XWD Meta Empty BMP PNG TIFF6 TIFF6-JAI JPEG-JAI JPEG PNM GIF89a+LZW XPM PSL1C PSL23+PDF PSL2+PDF-JAI P-TrOpBb.
sam2p.asan: Notice: job: read InputFile: POC_5
sam2p.asan: Notice: writeTTT: using template: l23
sam2p.asan: Notice: applyProfile: applied OutputRule #43 using applier PSL23+PDF
sam2p.asan: Notice: job: written OutputFile: /dev/null
Success.